London | 25-SDC-July | Priscilla Emebo | Sprint 2 | Shell pipelines#118
London | 25-SDC-July | Priscilla Emebo | Sprint 2 | Shell pipelines#118Priscilla-EM wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
Priscilla-EM
added
the
Needs Review
LonMcGregor
added
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this sprint. I have comments for just one file
| # The input for this script is the events.txt file. | ||
| # TODO: Write a command to show how many times anyone has entered and exited. | ||
| # It should be clear from your script's output that there have been 5 Entry events and 4 Exit events. | ||
| sort events.txt | uniq -c |
There was a problem hiding this comment.
This does not give output that makes it very clear how many entry and exits there have been. Can you figure out a way to make it more obvious there have been 5 entries and 4 exits?
There was a problem hiding this comment.
Thank you so much for the review! I have made the correction
LonMcGregor
added
Reviewed
|
Great, you're done with this sprint now |
LonMcGregor
added
Complete
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
2 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.